Refactor toplevel site.yml and fatimage.yml playbooks #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for the above image bump: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14660430262/job/41143461025 |
|
Interactive testing @ 3120e49: ✔️ ondemand shell |
wtripp180901
requested changes
Apr 30, 2025
This reverts commit aa11f43.
…site.yml, by default
|
Testing image build - should rebuild once fix/zenith merged to main anyway: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14778751137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to resolve a number of problems and inconsistencies between the
site.ymlandfatimage.ymlplaybooks. The major ones are:iam.ymlandslurm.ymlplaybooks are now run directly fromfatimage.ymlto make making changes to these less error-prone.compute-initexport task moved to a newfinal.ymlplaybook so it will run after any role which generates configuration which it might require.install.ymltask for this role also been moved here for consistency - note this changes commands used for development.gatewayrole which installs ansible-init playbook moved adjacent to ansible-init installsite.ymlandfatimage.ymlis now consistent in that repos are disabled after any post-hook in both cases.site.yml.compute_init,gateway) in groups hierarchy.See https://wiki.stackhpc.com/doc/slurm-top-level-playbooks-HW9BlHDMpm for more detail
TODO: needs image rebuilds!